[OI-110] Clang tidy Google Style Guide #155
Conversation
| - { key: readability-identifier-naming.StructCase, value: CamelCase } | ||
| - { key: readability-identifier-naming.TemplateParameterCase, value: CamelCase } | ||
| - { key: readability-identifier-naming.VariableCase, value: lower_case } | ||
| - { key: readability-identifier-naming.TemplateParameterIgnoredRegexp, value: 'expr-type'} |
There was a problem hiding this comment.
This needs to be added to avoid a bug in clang-tidy that only has been recently been fixed - llvm/llvm-project#46097
|
Kudos, SonarCloud Quality Gate passed!
|
RReichert
changed the title
RReichert
force-pushed
the
rodrigor/integrity-tidy
branch
from
b232e08
to
5e8c54e
Compare
RReichert
force-pushed
the
rodrigor/integrity-tidy
branch
from
a1a95d7
to
546b140
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Why are we doing this in CMake when this was already implemented in Bazel? We have a mandate (from the VP of engineering and the software VP) to migrate to Bazel, implementing new features in CMake takes us farther away from that goal. CMake should be considered as "maintenance mode" only -- new work in CMake should have a very clear justification why it's not possible in Bazel and DevInfra needs to be made aware so that we can plan to bring Bazel into parity.
…#155) (#1351) Automated PR by Jenkins. If CI has passed successfully, merge away! **cmake** 116c0f98 -> 38e6b7a8 - 38e6b7a8 : [OI-110] Clang tidy Google Style Guide (swift-nav/cmake#155) This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/14755/. [OI-110]: https://swift-nav.atlassian.net/browse/OI-110?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Changes
We can now specify an option to add further checks for our work in
orion-enginefor our ASIL compliance. These checks will validate that we are complying with our Google Style Guide.See: https://github.com/swift-nav/orion-engine/pull/6693 which uses this work to flag non compliance.