Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add FindUbx.cmake [STAR-840] #36

Merged
merged 1 commit into from
Oct 24, 2019
Merged

add FindUbx.cmake [STAR-840] #36

merged 1 commit into from
Oct 24, 2019

Conversation

yizow
Copy link
Contributor

@yizow yizow commented Oct 22, 2019

No description provided.

@yizow yizow changed the title add FindUbx.cmake add FindUbx.cmake [STAR-840] Oct 22, 2019
jbangelo
jbangelo approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jbangelo jbangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Adding Matt just to give a once over since he's been more directly involved with the CMake refactoring.

woodfell
woodfell approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@woodfell woodfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yizow yizow merged commit a76b347 into master Oct 24, 2019
This was referenced Dec 13, 2022
Closed
Closed
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Dec 20, 2022
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Feb 13, 2023
Merged
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Jan 4, 2024
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodfell woodfell woodfell approved these changes

@jbangelo jbangelo jbangelo approved these changes

@scarcanague scarcanague Awaiting requested review from scarcanague

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yizow @jbangelo @woodfell