Create new COG/SOG message #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkloh
pushed a commit
that referenced
this pull request
Jan 12, 2022
* Spec new COG_SOG message type * Generate C and Python code: * Add vertical velocity to message * Bump number of test-less messages * Generate more bindings * Add velocity mode flag to cog message * bump benchmark threshold, update generated artifacts * bump benchmark threshold again * Add test spec for cog message * add tests Co-authored-by: Jason Mobarak <[email protected]>
lkloh
pushed a commit
that referenced
this pull request
Jan 12, 2022
* Spec new COG_SOG message type * Generate C and Python code: * Add vertical velocity to message * Bump number of test-less messages * Generate more bindings * Add velocity mode flag to cog message * bump benchmark threshold, update generated artifacts * bump benchmark threshold again * Add test spec for cog message * add tests Co-authored-by: Jason Mobarak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design Notes
This PR sets up an SBP message type for a new velocity representation consisting of the course over ground and speed over ground. This is effectively a polar coordinate parameterization of the horizontal NED velocity vector.
The original proposal for this message type can be found here: https://swift-nav.atlassian.net/wiki/spaces/~643341576/pages/2096496752/COG+SOG+SBP+Message+Proposal
Remaining Work