Locked stdin and out for rust sbp2json

[adrian-kong]

Description

Locks the stdin and stdout for sbp2json

JIRA Reference

https://swift-nav.atlassian.net/browse/DEVINFRA-790

[notoriaga]

for edification this avoids acquiring a lock on a mutex for each read/write. the lock is always uncontested so in reality it's not a big deal (especially after the std mutex improvements). you still see a small perf boost though

hyperfine 'sbp2json <./tests/data/regression/2020-06-25-BayLoop/STEP_v2_SR_L2_OSR_staging_10Hz_GNSSOnly_AmotechL2/25-190704.sbp >/dev/null'
Benchmark 1: sbp2json <./tests/data/regression/2020-06-25-BayLoop/STEP_v2_SR_L2_OSR_staging_10Hz_GNSSOnly_AmotechL2/25-190704.sbp >/dev/null
  Time (mean ± σ):      5.132 s ±  0.027 s    [User: 4.896 s, System: 0.236 s]
  Range (min … max):    5.105 s …  5.194 s    10 runs

hyperfine 'sbp2json <./tests/data/regression/2020-06-25-BayLoop/STEP_v2_SR_L2_OSR_staging_10Hz_GNSSOnly_AmotechL2/25-190704.sbp >/dev/null'
Benchmark 1: sbp2json <./tests/data/regression/2020-06-25-BayLoop/STEP_v2_SR_L2_OSR_staging_10Hz_GNSSOnly_AmotechL2/25-190704.sbp >/dev/null
  Time (mean ± σ):      4.962 s ±  0.044 s    [User: 4.712 s, System: 0.249 s]
  Range (min … max):    4.900 s …  5.037 s    10 runs

[notoriaga]

I think the dockerfile in the rust folder needs to be updated to a newer version of rust. I'm guessing since 1.55 some borrowing rule was relaxed because the code compiles in the other workflows which use the latest version. can't find what actually changed though 🤔

[silverjam]

@adrian-kong Next thing we can try is to use MUSL to work around this issue... basically anywhere we call cargo build --release add --target=x86_64-unknown-linux-musl you'll probably need to reintroduce the installation of musl-tools to the Dockerfiles

[adrian-kong]

hmmmm if we change the target, it changes the target path from target/release -> target/x86_64-unknown-linux-musl/release, should we just change all the OS to use their specific binary targets so it wont just be target/release

[silverjam]

hmmmm if we change the target, it changes the target path from target/release -> target/x86_64-unknown-linux-musl/release, should we just change all the OS to use their specific binary targets so it wont just be target/release

I think it only does this if you're cross compiling, or manually specifying the build target.

[silverjam]

I think the latest failure is from the upgrade of hyperfine, the format of the json it outputs has probably changed... you'll need to run it locally to see what the new structure looks like (or rollback the upgrade if there wasn't a reason it was needed).

[silverjam]

Some slight slowdowns due to the switch to musl but I think we can live with that to get more universally compatible binaries