Finish porting test suite to Bazel [BUILD-311] #1223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
This PR adds the following bazel targets:
In the sbp-cpp-legacy-test,
SbpStdioTest.ReadsSbpFiles
andSbpStdioTest.WritesToSbpFiles
targets have undefined behavior. Assignment of msg to payload in theMsgObsHandler::handle_sbp_msg
function causes this issue.It works better with gcc-11 but still, these two testcases shouldn't be run together. In order to run all the test cases:
CC=gcc-11 CXX=g++-11 bazel test --test_output=all //c:all --test_arg=--gtest_filter=-SbpStdioTest.WritesToSbpFiles
CC=gcc-11 CXX=g++-11 bazel test --test_output=all //c:sbp-cpp-legacy-test --test_arg=--gtest_filter=SbpStdioTest.WritesToSbpFiles
JIRA Reference
https://swift-nav.atlassian.net/browse/BUILD-311