Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference only the runner name [OI-1830] #1416

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

fpezzinosn
Copy link
Contributor

Description

@swift-nav/devinfra

The Benchamarks Action has been failing since June 18th.
The last successful run of Benchmarks contains the following warning

Found multiple labels in this runner. Support for multiple labels on Larger Runners will be removed after June 17th, 2024. Please visit changelog for the brownouts and more details: https://github.blog/changelog/2024-05-16-new-dates-for-actions-larger-runner-multi-label-deprecation/.

Later runs start showing that no runners are picking up the job.

In this PR I'm changing the use of labels and instead only using the runner name. I have obtained that info from here.

API compatibility

Does this change introduce a API compatibility risk?

No, it only updates a github workflow file

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

JIRA Reference

https://swift-nav.atlassian.net/browse/OI-1830

@fpezzinosn fpezzinosn self-assigned this Jul 9, 2024
@fpezzinosn fpezzinosn requested a review from a team as a code owner July 9, 2024 17:48
@fpezzinosn fpezzinosn requested a review from pcrumley July 9, 2024 17:50
@@ -1,4 +1,4 @@
FROM rust:1.65-slim-buster
FROM rust:1.67.1-slim-buster
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated due to

error: package `cc v1.1.0` cannot be built because it requires rustc 1.67 or newer, while the currently active rustc version is 1.65.0
Either upgrade to rustc 1.67 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `cc` supporting rustc 1.65.0
Error: Process completed with exit code 101.

in https://github.com/swift-nav/libsbp/actions/runs/9861796299/job/27231017078?pr=1416

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm maybe just bump to 1.75?

Copy link

sonarcloud bot commented Jul 9, 2024

@fpezzinosn fpezzinosn enabled auto-merge (squash) July 9, 2024 19:36
@fpezzinosn fpezzinosn merged commit 6e46d19 into master Jul 9, 2024
13 checks passed
@fpezzinosn fpezzinosn deleted the fpezzinosn/fix-benchmark branch July 9, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants