Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESD-1238] Do not call nullary constructors in Haskell ToJSON #680

Merged
merged 3 commits into from
Apr 15, 2019
Merged

[ESD-1238] Do not call nullary constructors in Haskell ToJSON #680

merged 3 commits into from
Apr 15, 2019

Conversation

pmiettinen
Copy link
Contributor

@pmiettinen pmiettinen commented Apr 12, 2019 •
edited
Loading

Testing

  • Compare against Python output
{"crc":23106,"length":0,"msg_type":166,"payload":"","preamble":85,"sender":45490}
{"crc":23106,"length":0,"msg_type":166,"payload":"","preamble":85,"sender":45490}
{"crc":23106,"length":0,"msg_type":166,"payload":"","preamble":85,"sender":45490}
{"crc":23106,"length":0,"msg_type":166,"payload":"","preamble":85,"sender":45490}
{"crc":23106,"length":0,"msg_type":166,"payload":"","preamble":85,"sender":45490}

@pmiettinen pmiettinen force-pushed the pmiettinen/esd-1238-nullaries branch from 3cb528f to 2b45024 Compare April 12, 2019 13:19
@pmiettinen pmiettinen force-pushed the pmiettinen/esd-1238-nullaries branch from 2b45024 to 2907e1e Compare April 12, 2019 13:24
mfine
mfine reviewed Apr 12, 2019
View reviewed changes
Copy link
Contributor

@mfine mfine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me!

@pmiettinen pmiettinen merged commit db0f4e9 into master Apr 15, 2019
@pmiettinen pmiettinen deleted the pmiettinen/esd-1238-nullaries branch April 15, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfine mfine mfine left review comments

@silverjam silverjam silverjam approved these changes

@benjaminaltieri benjaminaltieri Awaiting requested review from benjaminaltieri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmiettinen @mfine @silverjam