Added classes for handling specific frame types and any frame #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbangelo
commented
Jan 3, 2020
jbangelo
force-pushed
the
jbangelo/add-cpp-frame-handler
branch
from
f1fc44e
to
c2c1ecd
Compare
RReichert
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was recently brought up that it might be helpful to have a way to handle any SBP message using the C++ classes. This PR adds the missing wrappers for handling raw frames of specific classes (corresponding to the
sbp_register_frame_callback()C function), and for handling all incoming frames/messages (corresponding to thesbp_register_all_msg_callback()C function).The interface for these were meant to be similar to the existing
MessageHandlerclass. They differ in that they only define a single virtual function to be implemented instead of one for each message type. This was done since these classes would typically be used for lower level access than is typical, and the such application code would probably want access to the raw bytes of data instead of a type safe reference.In addition to the code and example usage, a minor issue with the CMake files for the example was fixed as a part of this PR to help test the example.