Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcp_example error fix (signed /unsigned mismatch) #774

Merged
merged 1 commit into from
Jan 16, 2020
Merged

tcp_example error fix (signed /unsigned mismatch) #774

merged 1 commit into from
Jan 16, 2020

Conversation

horverno
Copy link
Contributor

@horverno horverno commented Jan 16, 2020 •
edited
Loading

fixing a small forgetfulness in the TCP example, the return of socket_read should be s32 instead of u32

silverjam
silverjam approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@silverjam silverjam merged commit 8ed57ac into swift-nav:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverjam silverjam silverjam approved these changes

@jkretzmer jkretzmer Awaiting requested review from jkretzmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horverno @silverjam