fixup font issue [INFRA-293] #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @silverjam |
|
Can you please check if the pdf generates successfully inside the libsbp-build docket container? I think the cmbright font is what was causing issues last time, but would be good to double check. |
|
tried to test this but I'm blocked waiting for #853 |
added 2 commits
September 21, 2020 13:45
Use the STIX font since it's available in LaTeX and recommended for technical documentation according to https://graphicdesign.stackexchange.com/a/517
|
@denniszollo I was seeing the same issue on the docker environment, picking a font seems to resolve the issue, I used the STIX font based on the recommendation from this web page: https://graphicdesign.stackexchange.com/a/517 |
|
Example of how the tables render now:
|
|
Sometimes text will overlap, but it's still readable:
|
silverjam
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 45 degree rotated text apparently was some kind of bitmap font and was rendering poorly on some systems. Removing cmbright fixes. Note, PDF doc may look and feel different after.