-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEN-466] new flags for fixed fuzed rate #880
[SEN-466] new flags for fixed fuzed rate #880
Conversation
The reported tow fields in the solutions are usually time of measurement (aka time of validity) and a flag should indicate otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will review; I think we can reconsider the wording a bit |
@denniszollo I'm getting antsy at merging 😅 😉 😁 ... |
desc: Type of Reported tow | ||
values: | ||
- 0: Time of Measurement | ||
- 1: Other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like somewhere we need to describe what "Other" could possible be. I suggest here in the intro paragraph. https://github.com/swift-nav/libsbp/pull/880/files#diff-1669e1e4c34cf7571c33296b08862bedd2a1ce937039283eb73a89b59631fcb7L13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback Dennis! 🎉 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename "Type of Reported tow" to "tow type"
- Add exposition about the field at the top of the "navigation" yaml where we orient people about what is going on and what "Time of measurement" means and what "other" means. Time of Measurement means only ONE thing, "other" could be a couple of things.
|
LGTM. |
age_gnss
inmsg_soln_meta
to indicate whether or not its value can be used to retrive the time of measurement of the fuzed solution. Useful in the context of pre-alignment, where the latest GNSS solution is forwarded at fuzed rate and timestamped from the IMU samples.0
, which also preserves all backward compatibilities.