Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEN-466] new flags for fixed fuzed rate #880

Merged
merged 11 commits into from
Nov 12, 2020

Conversation

GuillaumeDec
Copy link
Contributor

@GuillaumeDec GuillaumeDec commented Nov 5, 2020

  • Use highest two bits of age_gnss in msg_soln_meta to indicate whether or not its value can be used to retrive the time of measurement of the fuzed solution. Useful in the context of pre-alignment, where the latest GNSS solution is forwarded at fuzed rate and timestamped from the IMU samples.
  • Use the 5th bit of pos/vel flags to indicate whether the tow is time of measurement (== time of validity) or not. In almost all but the pre-alignment scenario, this is the case, so default value is 0, which also preserves all backward compatibilities.

@GuillaumeDec GuillaumeDec changed the title Guillaume/sen 466/new flags for fixed fuzed rate [SEN-466] new flags for fixed fuzed rate Nov 5, 2020
Copy link
Contributor

@reimerix reimerix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denniszollo
Copy link
Contributor

I will review; I think we can reconsider the wording a bit

@GuillaumeDec GuillaumeDec self-assigned this Nov 9, 2020
@GuillaumeDec
Copy link
Contributor Author

I will review; I think we can reconsider the wording a bit

@denniszollo I'm getting antsy at merging 😅 😉 😁 ...

desc: Type of Reported tow
values:
- 0: Time of Measurement
- 1: Other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like somewhere we need to describe what "Other" could possible be. I suggest here in the intro paragraph. https://github.com/swift-nav/libsbp/pull/880/files#diff-1669e1e4c34cf7571c33296b08862bedd2a1ce937039283eb73a89b59631fcb7L13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback Dennis! 🎉 🙏

Copy link
Contributor

@denniszollo denniszollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Rename "Type of Reported tow" to "tow type"
  2. Add exposition about the field at the top of the "navigation" yaml where we orient people about what is going on and what "Time of measurement" means and what "other" means. Time of Measurement means only ONE thing, "other" could be a couple of things.

@GuillaumeDec
Copy link
Contributor Author

  1. Rename "Type of Reported tow" to "tow type"
  2. Add exposition about the field at the top of the "navigation" yaml where we orient people about what is going on and what "Time of measurement" means and what "other" means. Time of Measurement means only ONE thing, "other" could be a couple of things.
  1. & 2. done ✅

@denniszollo
Copy link
Contributor

LGTM.

@GuillaumeDec GuillaumeDec merged commit a19489a into master Nov 12, 2020
@GuillaumeDec GuillaumeDec deleted the guillaume/sen-466/new-flags-for-fixed-fuzed-rate branch November 12, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants