Dzollo/sender id notes #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
screenshots to save you time on review:
|
dgburr
approved these changes
Dec 5, 2020
| description: Satellite observation messages from the device. | ||
| description: Satellite observation messages from the device. | ||
| The SBP sender ID of 0 indicates that observations | ||
| originated from a separate device such as a GNSS |
There was a problem hiding this comment.
Suggest using the phrase "remote observations" here since that would be more consistent with the terminology used in Swift Console as well as the Starling YAML config.
denniszollo
force-pushed
the
dzollo/sender_id_notes
branch
from
1a2592a
to
45e435b
Compare
* Move long note about sender_id to a footnote * Mention phrase "remote observations"
denniszollo
force-pushed
the
dzollo/sender_id_notes
branch
from
45e435b
to
414a7b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reimerix