SSR documentation clarification #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package-lock.json
Outdated
| "resolved": "https://registry.npmjs.org/util/-/util-0.10.3.tgz", | ||
| "resolved": "http://registry.npmjs.org/util/-/util-0.10.3.tgz", |
There was a problem hiding this comment.
Is this correct? I'd expect all addresses to be http**S**
There was a problem hiding this comment.
Hum that's a good point. This is automatically generated but Ill ping the libsbp channel to see if we can update the generator
package-lock.json
Outdated
Comment on lines
7526
to
7525
| "resolved": "https://registry.npmjs.org/util/-/util-0.10.3.tgz", | ||
| "resolved": "http://registry.npmjs.org/util/-/util-0.10.3.tgz", |
ljbade
approved these changes
Apr 23, 2021
scarcanague
force-pushed
the
sebastien/clarify_ssr_documentation
branch
from
a36db29
to
fefae2c
Compare
woodfell
pushed a commit
that referenced
this pull request
Apr 26, 2021
* Specification update * Automatic generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifying the code biases signal encoding and correcting a few nits