[ESD-2013] Add more test specs #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
requested review from
denniszollo,
jbangelo,
RReichert,
samvrlewis and
silverjam
RReichert
approved these changes
Apr 26, 2021
woodfell
force-pushed
the
woodfell/ESD-2013/add_test_specs
branch
2 times, most recently
from
f6744eb
to
4a1fd9b
Compare
woodfell
force-pushed
the
woodfell/ESD-2013/add_test_specs
branch
from
4a1fd9b
to
2ea9310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autogenerated tests don't cover a huge number of messages. A lot of them are quite old, some are organised as 1 spec file per module, some are 1 spec file per message type.
This PR tidies up the test specs by splitting up the per-module test specs to per-file specs and adding many more tests for more recent messages. The tests data was taken from an SBP recording from a test drive and covers all (most) of the messages produces and consumed by a recent starling-binary.
There is no attempt to cover every single SBP message, only the ones which are most likely to be used at the time of writing.
This PR covers just the test specs, the newly generated tests are moved over to a separate PR to keep this one easier to review - #964