[ESD-2032] Correct spec for fwd_payload member of MSG_FWD #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we deprecate and create a new message? |
Not sure. If we deprecate it and the old definition hangs around then we'd still need special handling for this string-but-not-a-string field such as the implementation of This change doesn't actually change the wire encoding, only how it's represented in the language bindings. There will be some changes to types all languages, not just C, but this message isn't exactly widely used. If you think this is too much of a change to make to the spec then it's probably better to just go with the special case sbp_binary_string_t in C |
silverjam
approved these changes
May 31, 2021
jayvdb
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fwd_payload is currently defined as a string. In reality the contents of this field is binary data with an undefined structure.
This isn't causing problems at the moment, most languages handle strings in a way which is suitable. For the improvements to the C bindings which are required for portability and language compliance this field encoding would need special handling. It can be simplified by altering it so that it's an array of u8 rather than a string.