-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: introduce a CMake based build for swift-format #677
Conversation
This does require swiftlang/swift-cmark#69 as well as swiftlang/swift-markdown#141 |
CC: @ahoppen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now other than the copyright headers still 😅. Same in the other linked PRs.
And would be good to run full toolchain builds in swiftlang/swift#70814 first.
Now that the base change is in, yes, it is possible to do the toolchain test - which is not a "good" but really a "must" as we risk breaking the Windows installer build at the very least and we need to ensure that the packaged content is correct. |
This is in preparation to use SwiftFormat from SourceKit-LSP which is distributed as part of the toolchain. On Windows, we are now able to build swift-format against the shared Swift Syntax package, yielding an overall size reduction: SPM swift-format.exe: 75,683,840 b CMake swift-format.exe: 830,464 b SwiftFormat.dll: 7,818,240 b Net Savings: 67,035,136 b
This is in preparation to use SwiftFormat from SourceKit-LSP which is distributed as part of the toolchain.
On Windows, we are now able to build swift-format against the shared Swift Syntax package, yielding an overall size reduction:
SPM
swift-format.exe: 75,683,840 b
CMake
swift-format.exe: 830,464 b
SwiftFormat.dll: 7,818,240 b
Net Savings: 67,035,136 b