Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check-license to properly check snippets #105

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Bug/issue #, if applicable: None

Summary

When snippets were introduced to swift-markdown, the check-source script wasn't updated to handle the way the license statement was written. This caused the bin/test script to start failing. This PR updates the check-source script to handle snippet files separately, since they have their license text written at the end of the file, instead of the beginning.

Dependencies

None

Testing

Ensure that bin/test (specifically bin/check-source) succeeds with the snippets in the repo.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • [ n/a ] Added tests
  • Ran the ./bin/test script and it succeeded
  • [ n/a ] Updated documentation if necessary

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

Copy link
Contributor

@bitjammer bitjammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thank you!

@QuietMisdreavus QuietMisdreavus merged commit 2c88ee5 into swiftlang:main Feb 6, 2023
@QuietMisdreavus QuietMisdreavus deleted the snippet-licenses branch February 6, 2023 17:15
@Kyle-Ye Kyle-Ye mentioned this pull request Jan 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants