Revert "Add support for Process stdin stream" #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7e8381f.
neonichu
requested review from
abertelrud,
aciidgh and
friedbunny
as code owners
|
@swift-ci please test |
artemcm
added a commit
to artemcm/swift-tools-support-core
that referenced
this pull request
Apr 12, 2021
This PR resurrects swiftlang#122, which we required in order to be able to forward standard input in the new swift-driver to the compile jobs it spawns. The change was previously reverted in swiftlang#143, due to an error seen on Linux.
artemcm
added a commit
to artemcm/swift-tools-support-core
that referenced
this pull request
Apr 12, 2021
This PR resurrects swiftlang#122, which we required in order to be able to forward standard input in the new swift-driver to the compile jobs it spawns. The change was previously reverted in swiftlang#143, due to an error seen on Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #122, as I suspect it broke TSC tests on Linux.
The "close error" in this failed job points to this code: https://ci.swift.org/job/swift-PR-Linux-smoke-test/25345/console
We just vendored these changes into SwiftPM yesterday.