[IDE] Resolve [.]Type completion for (any P). to produce singleto…

…n metatype instead of existential metatype. Resolves #65843
swiftlang · Apr 20, 2024 · 0fd78cb · 0fd78cb
1 parent bc4eeb8
commit 0fd78cb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/IDE/CompletionLookup.cpp b/lib/IDE/CompletionLookup.cpp
@@ -2437,7 +2437,8 @@ void CompletionLookup::getPostfixKeywordCompletions(Type ExprType,
   if (isa<TypeExpr>(ParsedExpr)) {
     if (auto *T = ExprType->getAs<AnyMetatypeType>()) {
       auto instanceTy = T->getInstanceType();
-      if (instanceTy->isAnyExistentialType()) {
+      if (instanceTy->isAnyExistentialType() &&
+          instanceTy->getCanonicalType()->is<ExistentialMetatypeType>()) {
         addKeyword("Protocol", MetatypeType::get(instanceTy),
                    SemanticContextKind::CurrentNominal);
         addKeyword("Type", ExistentialMetatypeType::get(instanceTy),

diff --git a/test/IDE/issue-65843.swift b/test/IDE/issue-65843.swift
@@ -0,0 +1,7 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-ide-test -batch-code-completion -source-filename %s -filecheck %raw-FileCheck -completion-output-dir %t
+
+protocol P {}
+
+(any P).#^COMPLETE?check=META^#
+// META: Keyword/CurrNominal:  Type[#(any P).Type#]; name=Type