[SR-9795] Cannot use super in lazy property: 'super' cannot be used outside of class members

[marcomasser]

Previous ID	SR-9795
Radar	None
Original Reporter	@marcomasser
Type	Bug

Environment

Tested with Swift 4.2.1 (Xcode 10.1) and Swift 5 from Xcode 10.2 beta (swiftlang-1001.0.45.7 clang-1001.0.37.7).

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug, StarterBug
Assignee	@theblixguy
Priority	Medium

md5: 75741cacf781b9db21044152b379d272

Issue Description:

I’m not sure this is a bug or if this works as expected:

class Foo {
    var name = "Default Name"
}

class Bar: Foo {
    lazy var fullName: String = {
        return super.name // error: 'super' cannot be used outside of class members
    }()
}

Is there a good reason why super isn’t permitted here? Replacing super with self works fine, as I’d expect because the instance must be fully initialized when lazy properties are accessed.

[belkadan]

Hm, I guess not. @slavapestov, can you think of a reason this would be disallowed after we allowed self?

[slavapestov]

It's just not implemented yet. Should be easy to fix; I suspect there's just an "is self of class method" check somewhere we need to generalize. Tagging as a starter bug

[theblixguy]

It seems to be happening inside `getImplicitSelfDeclForSuperContext()` because the `getInnermostMethodContext` returns nil (makes sense because the inner most context seems to be an `AbstractClosureExpr`). If you try dumping the decl context, it crashes.

I've sort of got it working by creating an implicit self decl from the innermost type context, but it crashes in CSGen, maybe because of the same reason it crashes in the parser.

[slavapestov]

The lazy initializer is type checked inside an Initializer context. It already has a self decl.

[slavapestov]

See `PatternBindingInitializer::getImplicitSelfDecl()`

[theblixguy]

Yes, I was trying to creating a `PatternBindingInitializer` earlier but ` getImplicitSelfDecl()` actually causes a crash in `getNumPatternEntries`.

[belkadan]

Where'd you leave off with this one, @theblixguy?

[slavapestov]

Might be worth giving this another shot – the lazy lowering code is a bit cleaner now, and things happen in requests so at least in theory it should be easier to get the ordering dependencies sorted out.

[theblixguy]

IIRC ` getImplicitSelfDecl` didn't work in that context so had to synthesise one and then tweak the constraint solver, but ended up with a crash in SILGen. I'll give it another try and put up a PR - maybe things have improved now.

[slavapestov]

It shouldn't require synthesizing anything new. 'super' is just a different way of writing 'self' and the fact that it doesn't work in all the places that 'self' works indicates there is some simplification that can be done.

[Overcot]

Hello. Is this issue available to be picked up? Where do i start with it? :)

[ricksentam]

I am also have the same question. Because I could not understand the first tour. Who or where could I ask for helping on dropping "dxxplet" and "land safely"? The biggest issue for me is the communication /connection seems offline? 「Alexey Ivashko ***@***.***>」在 2022年5月11日 週三，19:25 寫道：

Hello. Is this issue available to be picked up? Where do i start with it? :) — Reply to this email directly, view it on GitHub <#52220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APHMPZSGS7LBTA2BGXFENHTVJOKIZANCNFSM5VUSYQGQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- <Sent from ***@***.***>