DynamicCast Rework, Part 1: Specification #33010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
reviewed
Jul 20, 2020
CodaFi
reviewed
Jul 20, 2020
CodaFi
reviewed
Jul 20, 2020
CodaFi
reviewed
Jul 20, 2020
CodaFi
reviewed
Jul 20, 2020
CodaFi
reviewed
Jul 20, 2020
CodaFi
reviewed
Jul 20, 2020
CodaFi
reviewed
Jul 20, 2020
CodaFi
reviewed
Jul 20, 2020
CodaFi
reviewed
Jul 20, 2020
|
@tbkka had a thought. While this document is awesome I am worried about divergences. Really whatever behavior is specified here should have an associated test that validates this. I almost imagine that we could have a sub-folder of lit tests just for this spec. I am imagining that we would want anything that is specified to have an explicit link to the test that validates that an implementation obeys this spec. Take it or leave it = ). |
A test suite is in the works. |
|
@tbkka nice! The dream I was imagining inline links to the individual test cases. Thanks so much for your attention to detail here! = ). |
tbkka
commented
Jul 24, 2020
tbkka
commented
Jul 24, 2020
xwu
reviewed
Jul 26, 2020
xwu
reviewed
Jul 26, 2020
tbkka
force-pushed
the
tbkka/dynamicCastRework-pt1-Specification
branch
from
02e5922
to
6a5a8c2
Compare
tbkka
changed the title
tbkka
changed the title
tbkka
force-pushed
the
tbkka/dynamicCastRework-pt1-Specification
branch
from
6a5a8c2
to
5ba1827
Compare
|
@swift-ci Please smoke test |
CodaFi
approved these changes
Aug 17, 2020
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Sep 1, 2020
This validation test exercises a large matrix of types and invariants for dynamic casting. It's formulated as a Python script that emits a number of Swift test programs, compiles, and executes them. The programs are compiled in Swift 4 and 5 mode, with -O and -Onone. The invariants used by these tests follow the specification presented in PR swiftlang#33010. It should be easy to add more as desired. I've tried to design this in such a way that CI logs can provide enough information to narrowly identify the problem area: Separate test cases are generated for each invariant and each type (in particular, this helps with compiler crashes that report the full body of the function in question). The files and test suites are named to identify the optimization mode. The goal of this test suite is to cover a broad cross-section of casting capabilities and combinations, and to make it easy to expand the matrix of combinations. New invariants can easily be added and applied to many types; as new types are added to this test, they can exploit the existing invariants and be exercised across all optimization modes.
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Nov 2, 2020
This validation test exercises a large matrix of types and invariants for dynamic casting. It's formulated as a Python script that emits a number of Swift test programs, compiles, and executes them. The programs are compiled in Swift 4 and 5 mode, with -O and -Onone. The invariants used by these tests follow the specification presented in PR swiftlang#33010. It should be easy to add more as desired. I've tried to design this in such a way that CI logs can provide enough information to narrowly identify the problem area: Separate test cases are generated for each invariant and each type (in particular, this helps with compiler crashes that report the full body of the function in question). The files and test suites are named to identify the optimization mode. The goal of this test suite is to cover a broad cross-section of casting capabilities and combinations, and to make it easy to expand the matrix of combinations. New invariants can easily be added and applied to many types; as new types are added to this test, they can exploit the existing invariants and be exercised across all optimization modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed specification for dynamic casting, which has been under development as part of PR #29658
Splitting this out so it can be reviewed and merged separately from the implementation.