[WIP] Unify pool state #383
Conversation
|
✨ Deployment complete! Take a peek over at https://8fa2bafb.ui-storybook.pages.dev |
Deploying with
|
| Latest commit: |
29ac2a8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ff7a4d70.swim-ui.pages.dev |
| Branch Preview URL: | https://sdk-unify-pool-state.swim-ui.pages.dev |
wormat
force-pushed
the
sdk/unify-pool-state
branch
3 times, most recently
from
3463cac
to
2d74210
Compare
wormat
force-pushed
the
sdk/unify-pool-state
branch
from
7e37f59
to
68da6cc
Compare
wormat
force-pushed
the
sdk/unify-pool-state
branch
from
68da6cc
to
611eb34
Compare
wormat
force-pushed
the
sdk/unify-pool-state
branch
2 times, most recently
from
8c58bc9
to
1b6c2a3
Compare
wormat
force-pushed
the
sdk/unify-pool-state
branch
from
1b6c2a3
to
015649c
Compare
| interface DecimalBN { | ||
| readonly value: BN; | ||
| readonly decimals: number; | ||
| } | ||
|
|
||
| const decimal = (property = "decimal"): Layout<DecimalBN> => | ||
| struct([u64("value"), u8("decimals")], property); | ||
|
|
||
| interface AmpFactor { | ||
| readonly initialValue: DecimalBN; | ||
| readonly initialTs: BN; | ||
| readonly targetValue: DecimalBN; | ||
| readonly targetTs: BN; | ||
| } | ||
|
|
||
| const ampFactor = (property = "ampFactor"): Layout<AmpFactor> => | ||
| struct( | ||
| [ | ||
| decimal("initialValue"), | ||
| i64("initialTs"), | ||
| decimal("targetValue"), | ||
| i64("targetTs"), | ||
| ], | ||
| property, | ||
| ); |
There was a problem hiding this comment.
@nicomiicro I had to copy-paste these from the @swim-io/solana package because otherwise borsh complained that they weren't instances of Layout. Any ideas why? I thought the peer dependencies adjustment was supposed to prevent this kind of issue.
There was a problem hiding this comment.
I don't get a type error locally 🤔
I pushed 14b5fe3
Let's see the output of the CI https://github.com/swim-io/swim/actions/runs/3323839509/jobs/5494688131
There was a problem hiding this comment.
oh now I see it, it's a runtime error. Checking...
There was a problem hiding this comment.
oh yes, it's just because you are using the package from the workspace and not a published one. Thus it will load the one from its own node_modules. This should go away once it gets published.
There was a problem hiding this comment.
Another (good) reason to move to pre-releases for PRs?
There was a problem hiding this comment.
Ahh. Hmm, I don't really want to have to publish twice as often as I do currently.
There was a problem hiding this comment.
yeah I meant when we automate this...
| ({ id }) => id === lpTokenId, | ||
| ); | ||
| const poolTokens = tokenIds.map((tokenId) => | ||
| findOrThrow(this.chainConfig.tokens, ({ id }) => id === tokenId), |
There was a problem hiding this comment.
Won't this have the same issue I had with swimUSD not being present in this tokens list?
There was a problem hiding this comment.
Yes, nice catch, thanks!
There was a problem hiding this comment.
| const poolTokenDetails = tokenIds.map((tokenId) => { | ||
| const tokenConfig = findOrThrow( | ||
| this.chainConfig.tokens, | ||
| (token) => token.id === tokenId, |
There was a problem hiding this comment.
same question about swimUSD
A step towards creating a generic
Clientinterface. I'd be interested to hear suggestions on how to combine this approach with the current usage of React query/caching.Checklist