Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aptos: Add to liquidswap pool (WIP) #451

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from
Draft

Aptos: Add to liquidswap pool (WIP) #451

wants to merge 39 commits into from

Conversation

nicomiicro
Copy link
Contributor

@nicomiicro nicomiicro commented Oct 20, 2022 •
edited
Loading

Notion ticket: https://www.notion.so/exsphere/Aptos-integration-f6daa06ac05b48f490528c38a50ffd88

  • Creates a fake USDC in Aptos and a liquidswap pool with this USDC and our attested swimUSD
  • Updates UI config
  • Fixed a bug on token balance query method

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@nicomiicro nicomiicro added the feature New feature or request label Oct 20, 2022
@nicomiicro nicomiicro self-assigned this Oct 20, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 20, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c706d96
Status: ✅  Deploy successful!
Preview URL: https://9549dba7.swim-ui.pages.dev
Branch Preview URL: https://aptos-contracts-2tlh.swim-ui.pages.dev

View logs

@nicomiicro
Copy link
Contributor Author

I'm unsure on how to update src/core/selectors/swapTokenOptions.test.ts. Why do we have a different way to "disable" pools in there?

wormat
wormat reviewed Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

packages/aptos-contracts/README.md Outdated Show resolved Hide resolved
packages/aptos-contracts/README.md Outdated Show resolved Hide resolved
packages/aptos-contracts/Move.toml Outdated Show resolved Hide resolved
packages/aptos-contracts/sources/test_coin.move Outdated Show resolved Hide resolved
packages/aptos/src/ecosystem.ts
displayName: "Aptos USDC",
isStakingPool: false,
isStableSwap: true, // TODO is it?
isLegacyPool: false, // TODO, not legacy, not evm though, do we need a type here?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be removing this property from the SDK. Can you expand on the question here though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if a boolean is enough now that we introduce another pool type, since we filter with this in a few different places, but I guess I will figure out soon.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK won't have any legacy support, so this is purely a UI question. I don't have the full context so can't give an opinion beyond that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh so this flag is going to be removed then?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the SDK, yes. We'll be adding it to the UI pool type.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://www.notion.so/exsphere/Remove-any-kind-of-legacy-support-from-the-SDK-e2bb36ec76164d2e98de8a270296e9d8

packages/aptos/src/ecosystem.ts Outdated Show resolved Hide resolved
packages/aptos/src/client.ts Show resolved Hide resolved
apps/ui/src/config/pools.ts Show resolved Hide resolved
apps/ui/src/config/tokens.ts Show resolved Hide resolved
apps/ui/src/config/tokens.ts Show resolved Hide resolved
@swim-io swim-io deleted a comment from wormat Oct 20, 2022
wormat
wormat reviewed Oct 20, 2022
View reviewed changes
apps/attestation/README.md Outdated Show resolved Hide resolved
packages/aptos/src/ecosystem.ts
displayName: "Aptos USDC",
isStakingPool: false,
isStableSwap: true, // TODO is it?
isLegacyPool: false, // TODO, not legacy, not evm though, do we need a type here?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the SDK, yes. We'll be adding it to the UI pool type.

packages/aptos/src/ecosystem.ts
displayName: "Aptos USDC",
isStakingPool: false,
isStableSwap: true, // TODO is it?
isLegacyPool: false, // TODO, not legacy, not evm though, do we need a type here?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://www.notion.so/exsphere/Remove-any-kind-of-legacy-support-from-the-SDK-e2bb36ec76164d2e98de8a270296e9d8

wormat
wormat previously approved these changes Oct 20, 2022
View reviewed changes
@nicomiicro
Copy link
Contributor Author

@wormat I'll need your help with the publishing of the two packages 🙏

nicomiicro and others added 17 commits October 25, 2022 12:49
@nicomiicro
Merge branch 'aptos/contracts' into aptos/add-to-pool
eedbc49
@nicomiicro
chore(aptos): update contracts addresses
6619a0f
@nicomiicro
Merge pull request #462 from swim-io/aptos/update-wormhole-and-lp
c7a38c6 
Aptos: update wormhole and lp addresses
@nicomiicro
refactor(ui): define local AptosPoolState
dfcba14
@nicomiicro
refactor(aptos): remove AptosPoolState
cdf1422
@nicomiicro
refactor(aptos): tidy up utils and types
8b3c262
@nicomiicro
test(ui): update swapTokenOptions.test.ts.snap
eb5f30b
@nicomiicro
Merge branch 'aptos/contracts' into aptos/add-to-pool
9d0af66
@nicomiicro
refactor(aptos): rename const to constants
4f3fd60
@nicomiicro
refactor(aptos): rename getBalances to getPoolBalances
c7156f1
@nicomiicro
Merge pull request #460 from swim-io/aptos/add-to-pool
823318a 
Aptos: add to pool (WIP)
@nicomiicro
fix(ui): remove duplicate ecosystem array
9ed167c
@nicomiicro
fix(aptos): remove buggy liquidswap SDK
d3a923a
@nicomiicro
feat(aptos): Add getAddLiquidityTransactionPayload
f1d424b
@nicomiicro
feat(ui): Add to Aptos pool
4ea4f74 
without pool math and gas estimation...
@nicomiicro @wormat
chore(aptos): fix typo
ca3a003 
Co-authored-by: Will <[email protected]>
@nicomiicro
Merge pull request #468 from swim-io/aptos/add-to-pool-2
c706d96 
Aptos: Add to pool (basic - no pool math, no gas estimation)
@nicomiicro nicomiicro changed the title Aptos: pool contract and UI config Aptos: Add to liquidswap pool (WIP) Oct 26, 2022
@nicomiicro nicomiicro marked this pull request as draft October 26, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wormat wormat wormat left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@nicomiicro nicomiicro

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiicro @wormat