Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/wormhole form #453

Open
wants to merge 5 commits into
base: ui/wormhole-hooks
Choose a base branch
from
Open

UI/wormhole form #453

wants to merge 5 commits into from

Conversation

cyphertrace
Copy link
Contributor

@cyphertrace cyphertrace commented Oct 20, 2022 •
edited
Loading

Notion ticket: N/A

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@cyphertrace cyphertrace added the feature New feature or request label Oct 20, 2022
@cyphertrace cyphertrace self-assigned this Oct 20, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 20, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f500a9e
Status: ✅  Deploy successful!
Preview URL: https://afbb60e0.swim-ui.pages.dev
Branch Preview URL: https://ui-wormhole-form.swim-ui.pages.dev

View logs

@wormat wormat force-pushed the ui/wormhole-form branch 2 times, most recently from 62c60b7 to 2a63f9b Compare October 21, 2022 12:54
wormat
wormat reviewed Oct 21, 2022
View reviewed changes
apps/ui/src/components/TokenSearchModal.scss Outdated Show resolved Hide resolved
apps/ui/src/locales/en/translation.json Outdated Show resolved Hide resolved
apps/ui/src/locales/en/translation.json Outdated Show resolved Hide resolved
apps/ui/src/locales/en/translation.json Outdated Show resolved Hide resolved
apps/ui/src/locales/en/translation.json Outdated Show resolved Hide resolved
apps/ui/src/components/WormholeForm/WormholeForm.tsx Outdated Show resolved Hide resolved
apps/ui/src/components/WormholeForm/WormholeForm.tsx Outdated Show resolved Hide resolved
apps/ui/src/components/WormholeForm/WormholeForm.tsx Outdated Show resolved Hide resolved
apps/ui/src/components/WormholeForm/WormholeForm.tsx Outdated Show resolved Hide resolved
apps/ui/src/components/WormholeForm/WormholeForm.tsx Outdated Show resolved Hide resolved
wormat
wormat reviewed Oct 24, 2022
View reviewed changes
apps/ui/src/locales/en/translation.json Outdated Show resolved Hide resolved
apps/ui/src/pages/WormholePage.tsx
<EuiSpacer />
<WormholeForm />
</EuiPageContentBody>
<EuiPageContent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we still supposed to have an EuiPageContentBody?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find necessary that much element wrapping, as we have just form, it makes styling more difficult to handle.

apps/ui/src/components/WormholeForm/WormholeForm.scss Outdated Show resolved Hide resolved
apps/ui/src/config/wormhole.ts Outdated Show resolved Hide resolved
apps/ui/src/config/wormhole.ts Outdated Show resolved Hide resolved
apps/ui/src/components/TokenIcon.tsx Outdated Show resolved Hide resolved
apps/ui/src/components/TokenIcon.tsx Outdated Show resolved Hide resolved
apps/ui/src/components/WormholeForm/WormholeForm.tsx Outdated Show resolved Hide resolved
apps/ui/src/components/WormholeForm/WormholeForm.tsx Outdated Show resolved Hide resolved
apps/ui/src/components/WormholeForm/WormholeForm.tsx Outdated Show resolved Hide resolved
wormat
wormat reviewed Oct 24, 2022
View reviewed changes
apps/ui/src/config/wormhole.ts Outdated Show resolved Hide resolved
apps/ui/src/components/WormholeForm/WormholeForm.tsx Outdated Show resolved Hide resolved
apps/ui/src/config/wormhole.ts Outdated Show resolved Hide resolved
wormat
wormat approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's send it to manual testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wormat wormat wormat approved these changes

@nicomiicro nicomiicro Awaiting requested review from nicomiicro

@swimthor swimthor Awaiting requested review from swimthor

@ramenuncle ramenuncle Awaiting requested review from ramenuncle

Assignees

@cyphertrace cyphertrace

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyphertrace @wormat