Skip to content

Commit

Permalink
Adjust test condition to look only for engine related warning
Browse files Browse the repository at this point in the history
  • Loading branch information
rmarquis committed Apr 12, 2024
1 parent 49fcf45 commit 1003dbd
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions tests/test_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def unreachable_engine_instance_fixture(httpserver: HTTPServer):
def app_with_reachable_engine_instance(reachable_engine_instance: HTTPServer):
def get_settings_override():
settings = get_settings()
settings.engine_urls = reachable_engine_instance.url_for("")
settings.engine_urls = [reachable_engine_instance.url_for("")]
settings.engine_announce_retries = 2
settings.engine_announce_retry_delay = 1
settings.max_tasks = 2
Expand All @@ -83,7 +83,7 @@ def get_settings_override():
def app_with_unreachable_engine_instance(unreachable_engine_instance: HTTPServer):
def get_settings_override():
settings = get_settings()
settings.engine_urls = unreachable_engine_instance.url_for("")
settings.engine_urls = [unreachable_engine_instance.url_for("")]
settings.engine_announce_retries = 2
settings.engine_announce_retry_delay = 1
settings.max_tasks = 2
Expand Down Expand Up @@ -111,10 +111,11 @@ def test_announce_to_reachable_engine(
# This is not a good way to test the app as any other warnings will make the test
# passes.
warning_logs_found = False
# for record in caplog.records:
# if record.levelname == "WARNING":
# warning_logs_found = True
# break
for record in caplog.records:
if record.levelname == "WARNING":
if "Failed to notify the engine" in record.message:
warning_logs_found = True
break

assert not warning_logs_found

Expand All @@ -134,8 +135,9 @@ def test_announce_to_unreachable_engine(
warning_logs_found = False
for record in caplog.records:
if record.levelname == "WARNING":
warning_logs_found = True
break
if "Failed to notify the engine" in record.message:
warning_logs_found = True
break

assert warning_logs_found

Expand Down

0 comments on commit 1003dbd

Please sign in to comment.