Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to vue 3 #100

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

chore: migrate to vue 3 #100

wants to merge 27 commits into from

Conversation

fdendorfer
Copy link
Collaborator

@fdendorfer fdendorfer commented Sep 19, 2024 •
edited
Loading

Summary

  • Move from npm to pnpm
  • Upgrade vue 2 to vue 3
    • Convert vue files to options api
    • Convert storybook store to pinia
    • Replace mitt with vue native emits or postMessage calls
    • Upgrade nuxt 2 to nuxt 3
    • Rename static/ to public/
  • Move from JS to TS
    • Added some global interfaces for better props support
    • Added tsconfig for type completition in vue components
    • Consistently use esm over commonjs imports (mostly in app/scripts/)
  • Upgrade storybook from v6 to v8
    • Move from webpack to vite
    • Convert mdx stories to separate story format v3 (component.stories.mdx -> component.stories.js + component.mdx)
  • modal.postcss: spcified open='true' because vue 3 writes the property as open="false" when not open
  • carousel.postcss: removed overflow:clip because it prevented the arrows from being shown
  • accordion.postcss: fixed accordion caret from expanding when opened, by adding display:flex
  • Added prettier for consistent code formatting
  • Added eslint for static code analysis (syntax errors, security issues, code smells and consistency)
  • Added some app/package.json scripts for easier execution of linters/formatters
  • Upgrade various minor packages in app/package.json
  • Removed import aliases to avoid inconsistency
  • Fixed various typos
    • SocialsSection.vue
      • feed.pofileURL -> feed.profileURL
    • Badge.vue
      • highlighCancel -> highlightCancel
    • glossar.vue, BadgeFilter.vue, CarouselBadgeFilter.vue, indexPage.vue
      • numbric -> numeric
    • OrderBox.vue
      • curencyPrefix -> currencyPrefix

@gebelj gebelj force-pushed the chore/upgrade-vue-3 branch 2 times, most recently from e82727a to 97b6574 Compare September 20, 2024 06:46
@fdendorfer fdendorfer force-pushed the chore/upgrade-vue-3 branch 4 times, most recently from 96505bd to 8e36dc7 Compare September 20, 2024 07:30
@gebelj gebelj force-pushed the chore/upgrade-vue-3 branch 2 times, most recently from 7a53608 to 5a55748 Compare September 20, 2024 10:05
@fdendorfer fdendorfer force-pushed the chore/upgrade-vue-3 branch 10 times, most recently from b735c0d to 8153de3 Compare September 25, 2024 06:08
fdendorfer
fdendorfer commented Oct 4, 2024
View reviewed changes
app/scripts/Navy.js Outdated Show resolved Hide resolved
@fdendorfer fdendorfer marked this pull request as ready for review October 18, 2024 14:20
@fdendorfer fdendorfer force-pushed the chore/upgrade-vue-3 branch 3 times, most recently from b9d4883 to ee781ed Compare October 24, 2024 13:38
Florian Dendorfer and others added 7 commits October 28, 2024 15:35
base nuxt 3
c96aa4c 
- upgrade nuxt and nuxt modules
- move static/ to public/
Update Nuxt and TS config, add o2c, update plugins, stores and util s…
bc100dc 
…cripts
Migrate components to vue3
b9c6fe0
Upgrade storybook
a30a605
Add some todos for later
0ebd254
@gebelj
Revert comments and todo for merge
fe8ed62
@fdendorfer @gebelj
chore: upgrade storybook (#110)
5e4f01e 
* upgrade dependencies

* update more dependencies

* Run codemode for mdx to csf

* Get storybook running

* Stories and components cleanup

* Fix Video component

* Fix Colors stories and ColorList component

* Add remark-gfm for autolink literals, footnotes, strikethrough, tables and task lists

* Fix TagItem Story

* Fix Fonts stories

* Fix Table Story and update TagItem Story

* Fix Backgrounds stories

* Update Video Stories to new format

* Updated tabs Story to new format

* Show code fixes

* Fix Slideshow story

* Tag Item Docs

* Fix separator story

* Fix Print Story

* Fix popover story and description values in control

* Icon stories fixes

* Sections stories fixes

* Fix pagination story

* Change props of pagination back and extend args instead

* Fix NotificationBanner story (Change pagination props back)

* Fix Containers stories

* Fix notification story

* Fix Grids stories

* Fix Spacings stories

* Change notifications back to original templates

* Fix newsletter story

* Fix Ratios stories

* Fix Logo stories

* Fix modal story

* Fix Metainfo story

* Update Metainfo story and fix Link story

* Fix downloaditem and list stories (TODO: list dot)

* Fix Button stories and change canvas styles to classes

* Fix textarea story

* Fix lists and form paddings

* Fix Accordion styles

* Fix AlertBanner stories

* Fix AudioPlayer stories

* Fix Authors stories

* Fix BackToTopBtn stories

* Fix Badge stories

* Fix Select story

* Fix Radio Story

* Fix Card stories

* Fix multiselect story (Still go a todo)

* Replace mitt with native emits and postMessage

* Fix input story

* Fix Carousel stories

* Fix DesktopMenu stories

* Fix fieldset story

* Fix Checkbox story

* Fix Header Section stories

* Fix layouts in some stories (Badge, Btn, Breadcrumb)

* Fix footer folder stories

* Fix Homepage stories

* Fix Easy & Sign Language stories
- also fixed all links in the stories

* Fix socials, MoreInfos, Portrait, Quote stories

* Fix DateBox Story

* Fix ContactSection story

* Fix Hero stories

* Fix fieldset display of legend prop

* Fix props order of pagination and notificationBanner

* Fix Detail Page Event stories

* Fix pages stories

* Fix pages (intranet to test spacings)

* Fix Glossar page (Select component to be exact)

* Fix fieldset slots and tabs args

* Fixed shoppingcart and form pages and table widths

* Fix model props declarations

* Fix Publication folder pages

* Fix card story background and spacing

* Fix language pages

* Rename highlighCancel to highlightCancel in Badge

* Upgrade minor dependencies and remove unused files

* Fix multiselect library (#116)

* Render multiselect component again

* Fix multiselect component

* General cleanup

---------

Co-authored-by: gebelj <[email protected]>
Co-authored-by: Florian Dendorfer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdendorfer @gebelj