Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate resolution after upload #649

Merged
merged 6 commits into from
Sep 29, 2024
Merged

Invalidate resolution after upload #649

merged 6 commits into from
Sep 29, 2024

Conversation

swissspidy
Copy link
Owner

@swissspidy swissspidy commented Aug 31, 2024

Doesn't work yet, the invalidateResolution calls don't seem right.

To-do:

  • Add test that the sizes control appears

Fixes #648
Fixes #695

@swissspidy swissspidy added the enhancement New feature or request label Aug 31, 2024
Copy link

github-actions bot commented Aug 31, 2024

Size Change: -19 B (0%)

Total Size: 7.31 MB

ℹ️ View Unchanged
Filename Size Change
build/100.js 89.6 kB 0 B
build/699.js 2.35 MB 0 B
build/ai.worker.js 178 kB 0 B
build/blurhash.worker.js 3.23 kB 0 B
build/canvas.worker.js 2.79 kB 0 B
build/chunk-ffmpeg.js 5.92 kB 0 B
build/chunk-selfie-segmentation.js 16.3 kB 0 B
build/dominant-color.worker.js 4.45 kB 0 B
build/ffmpeg.js 1.09 kB 0 B
build/heif.worker.js 450 kB 0 B
build/media-experiments-blocks-rtl.css 318 B 0 B
build/media-experiments-blocks.css 318 B 0 B
build/media-experiments-rtl.css 1.03 kB 0 B
build/media-experiments.css 1.03 kB 0 B
build/media-experiments.js 79.9 kB -19 B (-0.02%)
build/pdf.js 579 B 0 B
build/subtitles.js 850 B 0 B
build/view-upload-request-view-rtl.css 697 B 0 B
build/view-upload-request-view.css 699 B 0 B
build/view-upload-request.js 19 kB 0 B
build/vips-heif.********.wasm 1.27 MB 0 B
build/vips-jxl.********.wasm 800 kB 0 B
build/vips.********.wasm 2 MB 0 B
build/vips.worker.js 37.9 kB 0 B

compressed-size-action

@swissspidy
Copy link
Owner Author

Add test that the sizes control appears

Might be easiest once minimum requirement is increased. Otherwise have to add a version check.

@swissspidy swissspidy marked this pull request as ready for review September 29, 2024 12:16
@swissspidy swissspidy merged commit b35174c into main Sep 29, 2024
25 checks passed
@swissspidy swissspidy deleted the fix/648-invalidate branch September 29, 2024 12:30
swissspidy added a commit that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove onSuccess from OnSuccessHandler in media-utils Invalidate getMedia resolution on success
1 participant