Use TERM_PROGRAM for determining WezTerm terminal

[MuhammedZakir]

Currently, TERM is used, which is not set by default.

Ref: #182 (comment)

Edit: update manpage to mention WezTerm and fix typos.

[swsnr]

Thanks 🙏

[swsnr]

Thanks a lot, especially for the rigorous proof reading of the manpage 🙏 Much obliged 🤗

[SuperSandro2000]

It should fallback to TERM which it now no longer does.

The reason why wezterm does not set TERM by default is that it breaks WSL and ssh targets which do not have the terminfo installed and there is no easy way to automatically do it or forward that info.

[SuperSandro2000]

Also $TERM_PROGRAM is some arbitrary environment variable which is not set by wezterm or is documented in any of my manpages.

[MuhammedZakir]

Also $TERM_PROGRAM is some arbitrary environment variable which is not set by wezterm or is documented in any of my manpages.

Before changing, I did look at the code, and WezTerm do set TERM_PROGRAM and TERM_PROGRAM_VERSION^[1][2]. Also, Wez himself said to use it ^[3].

[1] https://github.com/wez/wezterm/blob/ac5199c21663e39dcce887308a92b5e36b338866/config/src/lib.rs#L1711
[2] https://github.com/wez/wezterm/search?q=TERM_PROGRAM&type=commits
[3] wez/wezterm#230 (comment)

[SuperSandro2000]

That only works if you are opening the shell locally on a Linux machine. Everyone needs to duct tape around this when using WSL or SSH. Just use TERM as a fallback instead of some random other environment variable.

[SuperSandro2000]

Forwarding the variable over ssh is not that easy because it needs both changes in the client and server config of ssh. Also I am pretty sure there are pieces of software which will also needs special treatment which is totally unnecessary here.

[swsnr]

@SuperSandro2000 I am sorry but I don't like your tone; please try to be less combative and less passive aggressive. Thanks.

mdcat will continue to use TERM_PROGRAM because unlike TERM it works by default whereas TERM needs additional configuration, at least in my experience.

I understand that it doesn't work over SSH by default, but neither does TERM without copying terminfo files around. I'd also like to point out that iTerm detection also relies on TERM_PROGRAM only, and so far I haven't received any complaints about this.

I am not opposed to checking additional environment variables, but personally I have no need to change this, and please understand that you are not entitled to demand this from @MuhammedZakir.

If you need a fallback to TERM please do make a pull request yourself. I'd be happy to review it. Thanks.

[SuperSandro2000]

If you need a fallback to TERM please do make a pull request yourself.

I am doing that right now.

[swsnr]

@SuperSandro2000 Thank you 🙏