-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gridView): implement feature (#24) #25
Conversation
Some latest version is not avaliable now. It will cause GitHub Action failed.
As I mention in 0a4e61c, some packages (dependencies) version are not available now, so the check will failed for several days. If checking locally, everything should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Thanks for the really quick development on this - it's a really nice implementation. I just had some comments on the m_gri()
options but that was it.
- expose config options - autoc-compute rows / cols
if (is.null(rows)) { | ||
rows <- ceiling(sqrt(length(viewer))) | ||
} | ||
|
||
if (is.null(cols)) { | ||
cols <- ceiling(length(viewer) / rows) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brilliant implemantation! I'm really bad at math...
Looks good, wait for the checks to be completed and then merge it to master. |
Looks good! Merged 🎉🎉 |
A dirty solution, but it works.