Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodegroup support to control system and interpolation framework #6172

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

nilsdeppe
Copy link
Member

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 self-requested a review July 20, 2024 16:22
Comment on lines 38 to +39
const ArrayIndex& /*array_index*/,
tnsr::I<DataVector, Metavariables::volume_dim,
tnsr::I<DataVector, Dim,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had added comments for the previous commits asking to do the opposite of this. Could you give a brief explanation? Was this necessary to compile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've generally found "reaching up" into the metavariables to be fairly brittle and tricky. Considering we deduce the dim pretty much everywhere in the code I saw no reason to avoid doing that here. I've also sometimes had issues with GCC not being able to retrieve Metavaraibles::volume_dim and those were extremely difficult to debug, so I feel like suggesting that as the "default" is not really a good thing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree in general we shouldn't reach up, but I thought the volume_dim was an exception since it's so ubiquitous in our metavars. We also do this a lot throughout the code for the dim, so we aren't really consistent. But if it's causing issues with GCC then passing in the Dim explicitly is ok

@nilsdeppe
Copy link
Member Author

@knelli2 I pushed fixups. Thanks for the review :)

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can squash

@nilsdeppe
Copy link
Member Author

Rebased and squashed. Thanks for the reviews!

@nilsdeppe nilsdeppe merged commit c5e1483 into sxs-collaboration:develop Aug 21, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants