Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ADM integrals observer to the finest grid. #6286

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

iago-mendes
Copy link
Member

Proposed changes

Before this PR, the ADM integrals observer was summing over all grids, which becomes a problem when using multigrid for the linear solver. With this PR, we limit the reduction to only the finest grid.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu merged commit 7749b4e into sxs-collaboration:develop Sep 12, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants