-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SHA-224 for PKCS1 signatures #104
Conversation
b5b121a
to
3f0dc88
Compare
3f0dc88
to
47ca8ab
Compare
In doc/usage.rst, you mention key size recommendations. What is the source or reason behind these recommendations? I'm unsure how to make a similar recommendation for SHA-224. |
47ca8ab
to
69e144f
Compare
That is a very good question... You can see that I wrote that before I got my Ph.D., nowadays I would certainly have added a reference ;-) Looking at that list now, I agree with you that it's hard to make a good recommendation. Searching for "SHA-512 752" shows the Python-RSA documentation as top hit, which means that this is not a widely used recommendation. Let's just drop it, and suggest people to use modern recommendations for the key size from, for example, NIST Special Publication 800-131A. At this time they simply recommend RSA keys of at least 2048 bits. |
69e144f
to
0d83823
Compare
That sounds very reasonable. I've submitted a different pull request that removes the whole key size discussion. |
Since version 2.2, PKCS1 also includes SHA-224. Since it's available in
hashlib
, adding support was straight-forward. I've omitted SHA-512/224 and SHA-512/256 for now, since the fact that they're not inhashlib
would make it a bit clunky.