Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.12 and drop EOL 3.7 #223

Merged
merged 11 commits into from
Nov 1, 2023
Merged

Add support for Python 3.12 and drop EOL 3.7 #223

merged 11 commits into from
Nov 1, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Aug 28, 2023

The Python 3.12 release candidate is out! 🚀

Call to action

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.12 compatibilities during this phase, and where necessary publish Python 3.12 wheels on PyPI to be ready for the final release of 3.12.0.

See also https://dev.to/hugovk/help-test-python-312-beta-1508/

Also drop EOL Python 3.7: https://devguide.python.org/versions/

sybrenstuvel
sybrenstuvel requested changes Sep 4, 2023
View reviewed changes
Copy link
Owner

@sybrenstuvel sybrenstuvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This has many desirable changes :) I've left some inline notes.

rsa/cli.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
doc/conf.py Show resolved Hide resolved
rsa/pkcs1.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@hugovk
Copy link
Contributor Author

hugovk commented Sep 4, 2023

Thanks for the review, how does this look now?

@sybrenstuvel sybrenstuvel merged commit 4d78cca into sybrenstuvel:main Nov 1, 2023
7 checks passed
@sybrenstuvel
Copy link
Owner

Looking good, thanks again!

@hugovk hugovk deleted the add-3.12 branch November 1, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sybrenstuvel sybrenstuvel sybrenstuvel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @sybrenstuvel