Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes React imports when using web beautify. #11179

Closed
wants to merge 1 commit into from
Closed

Fixes React imports when using web beautify. #11179

wants to merge 1 commit into from

Conversation

i-oliva
Copy link
Contributor

@i-oliva i-oliva commented Aug 15, 2018

This fixes web-beautify formatting with imports.

@sdwolfz
Copy link
Collaborator

sdwolfz commented Aug 15, 2018

Can you please explain what this does with an example? I am not familiar with the functionality.

@i-oliva
Copy link
Contributor Author

i-oliva commented Aug 15, 2018

Basically this beautifier/js-beautify#382 (comment)

This just helps web beautify to do the expected job (not to jump to a new line on imports, which look ugly and unconventional)

@sdwolfz
Copy link
Collaborator

sdwolfz commented Aug 15, 2018

Thank you ❤️!
And congratulations on your first Spacemacs PR 🎉!

I did not notice it was a documentation change. This should be harmless then, I was afraid of having a default config that broke other people's autoformat rules, but this should be fine.

Cherry-picked into develop branch, you can safely delete your branch.

@sdwolfz sdwolfz closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants