-
Notifications
You must be signed in to change notification settings - Fork 226
Conversation
"type": "vcs", | ||
"url": "https://github.com/WouterJ/assetic" | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be removed once kriswallsmith/assetic#772 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is merged now
The build failure is unrelated to this PR. |
@@ -26,16 +26,11 @@ matrix: | |||
env: SYMFONY_VERSION=2.7.* | |||
# Test against dev versions | |||
- php: 5.6 | |||
env: DEPENDENCIES=dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't remove the test against dev dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we allow this test to fail ?
Do you want to wait until https://github.com/kriswallsmith/assetic is released? |
This PR doesn't assure the compatibility with Symfony3 until you add the dependency with |
There is no need to use this constraint as composer will manage this automatically. |
Your composer file must manage its own dependencies. If you install this component using ping @stof |
If an user wants to use symfony 3.0, composer will only install the versions of the dependencies that are compatibles. If you use |
Not agree.
So, what you have to do here is increment your dependency with assetic library, and if other users need Symfony |
An example: {
"require": {
"php": ">=5.3.9",
"symfony/symfony": "^3.0@dev",
"symfony/assetic-bundle": "^2.0",
"kriswallsmith/assetic": "^1.3"
}
}
With this
Because if for example composer installs |
@mmoreram don't confuse Twig 2.x and Symfony 3. Symfony 3 still allows Twig 2 |
The remaining test failure on PHP 7 is because of sebastianbergmann/phpunit-mock-objects#267 |
Thank you @Ener-Getick. |
This PR was merged into the 2.7-dev branch. Discussion ---------- Add symfony 3.0 support This PR adds symfony 3.0 support. Commits ------- 1482825 Add symfony 3.0 support
This PR adds symfony 3.0 support.