-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Doctrine DBAL 4 and ORM 3 #1494
Conversation
Will check how to get rid of this deprecation
|
Needs dmaicher/doctrine-test-bundle#281 first |
865431b
to
e4f0a5b
Compare
e4f0a5b
to
df3ea92
Compare
@@ -23,6 +23,8 @@ | |||
* See https://symfony.com/doc/current/security/voters.html | |||
* | |||
* @author Yonel Ceruto <[email protected]> | |||
* | |||
* @extends Voter<non-empty-string, Post> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also see phpstan/phpstan#10573
Using non-empty-string
to avoid
------ -------------------------------------------------------------------------------------
Line src/Security/PostVoter.php
------ -------------------------------------------------------------------------------------
37 Asserted type string for $attribute with type string does not narrow down the type.
------ -------------------------------------------------------------------------------------
I thought this would require more changes on our side, so I'm happy it doesn't. David, thanks a lot for taking care of this ... and also for making the needed updates in your great |
No description provided.