Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Doctrine DBAL 4 and ORM 3 #1494

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

dmaicher
Copy link
Contributor

No description provided.

@dmaicher dmaicher changed the title Upgrade to Dotrine DBAL 4 and ORM 3 Upgrade to Doctrine DBAL 4 and ORM 3 Feb 15, 2024
@dmaicher
Copy link
Contributor Author

Will check how to get rid of this deprecation

   44x: Doctrine\DBAL\Connection::setNestTransactionsWithSavepoints is deprecated and will be removed in 5.0 (Connection.php:948 called by App_KernelTestDebugContainer.php:611, https://github.com/doctrine/dbal/pull/5383, package doctrine/dbal)
    10x in BlogControllerTest::setUp from App\Tests\Controller\Admin
    5x in DefaultControllerTest::tearDown from App\Tests\Controller
    4x in BlogControllerTest::testNewComment from App\Tests\Controller
    2x in AddUserCommandTest::testCreateUserNonInteractive from App\Tests\Command
    2x in AddUserCommandTest::testCreateUserInteractive from App\Tests\Command
    

@dmaicher
Copy link
Contributor Author

Needs dmaicher/doctrine-test-bundle#281 first

@@ -23,6 +23,8 @@
* See https://symfony.com/doc/current/security/voters.html
*
* @author Yonel Ceruto <[email protected]>
*
* @extends Voter<non-empty-string, Post>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see phpstan/phpstan#10573

Using non-empty-string to avoid

 ------ ------------------------------------------------------------------------------------- 
  Line   src/Security/PostVoter.php                                                           
 ------ ------------------------------------------------------------------------------------- 
  37     Asserted type string for $attribute with type string does not narrow down the type.  
 ------ ------------------------------------------------------------------------------------- 

@javiereguiluz
Copy link
Member

I thought this would require more changes on our side, so I'm happy it doesn't. David, thanks a lot for taking care of this ... and also for making the needed updates in your great doctrine-test-bundle

@javiereguiluz javiereguiluz merged commit a2073d0 into symfony:main Feb 16, 2024
6 checks passed
@dmaicher dmaicher deleted the orm_dbal_upgrade branch February 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants