Adding precision on PANTHER_NO_HEADLESS behavior #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -382,12 +382,12 @@ $client = self::createPantherClient([ | |||
| #### Chrome-specific Environment Variables | |||
|
|
|||
| * `PANTHER_NO_SANDBOX`: to disable [Chrome's sandboxing](https://chromium.googlesource.com/chromium/src/+/b4730a0c2773d8f6728946013eb812c6d3975bec/docs/design/sandbox.md) (unsafe, but allows to use Panther in containers) | |||
| * `PANTHER_CHROME_ARGUMENTS`: to customize Chrome arguments. You need to set `PANTHER_NO_HEADLESS` to fully customize. | |||
| * `PANTHER_CHROME_ARGUMENTS`: to customize Chrome arguments. You need to set `PANTHER_NO_HEADLESS` to a true value to have full control of arguments. | |||
There was a problem hiding this comment.
(same below)
Suggested change
| * `PANTHER_CHROME_ARGUMENTS`: to customize Chrome arguments. You need to set `PANTHER_NO_HEADLESS` to a true value to have full control of arguments. | |
| * `PANTHER_CHROME_ARGUMENTS`: to customize Chrome arguments. You need to set `PANTHER_NO_HEADLESS` to `1` to have full control over arguments. |
| @@ -357,7 +357,7 @@ Since Panther implements the API of popular libraries, it already has an extensi | |||
|
|
|||
| The following environment variables can be set to change some Panther's behaviour: | |||
|
|
|||
| * `PANTHER_NO_HEADLESS`: to disable the browser's headless mode (will display the testing window, useful to debug) | |||
| * `PANTHER_NO_HEADLESS`: if defined and true, then it disables Panther's default use of headless mode with a 1200x1100 window (and disable GPU for chrome) | |||
There was a problem hiding this comment.
this is documenting internal details that might change (see eg #640) so I'm not sure about the benefit of stating this 🤔
Suggested change
| * `PANTHER_NO_HEADLESS`: if defined and true, then it disables Panther's default use of headless mode with a 1200x1100 window (and disable GPU for chrome) | |
| * `PANTHER_NO_HEADLESS`: set to `1` to disable Panther's use of headless mode and thus see what happens in a browser window |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.