Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Doctrine mappings YML from documentation #20050

Closed
cosminsandu opened this issue Jul 18, 2024 · 4 comments
Closed

Remove Doctrine mappings YML from documentation #20050

cosminsandu opened this issue Jul 18, 2024 · 4 comments
Labels
Doctrine hasPR A Pull Request has already been submitted for this issue.

Comments

@cosminsandu
Copy link
Contributor

Since Doctrine 3.0 does not support YML configuration (see doctrine/DoctrineBundle#1071 https://github.com/doctrine/orm/blob/3.0.x/UPGRADE.md#bc-break-remove-yaml-mapping-drivers https://github.com/doctrine/orm/blob/3.0.x/UPGRADE.md#deprecated-yaml-mapping-drivers ) Doctrine Configuration Reference (DoctrineBundle) documentation > Mapping Configuration > type should be updated to not contain yml format anymore.

please let me know if it is ok to remove the yml option from documentation.
@javiereguiluz javiereguiluz added the Waiting team decision Request for comments from Symfony Docs Team members label Jul 18, 2024
@cosminsandu
Copy link
Contributor Author

I think it should be a deprecated message - as in case of Annotations (on version 6.4 )

image

Please let me know on which Symfony version should I add this change.

@xabbuh
Copy link
Member

xabbuh commented Jul 19, 2024

We can do the change in the 5.4 branch as Doctrine ORM 3 is usable with Symfony 5.4.

cosminsandu pushed a commit to cosminsandu/symfony-docs that referenced this issue Jul 19, 2024
issues/20050 Remove Doctrine mappings YML from documentation
1a22c51 
symfony#20050
@cosminsandu cosminsandu mentioned this issue Jul 19, 2024
Merged
@cosminsandu
Copy link
Contributor Author

cosminsandu commented Jul 19, 2024 •
edited
Loading

Looks like I need to add .. deprecated:: to a version of Symfony but in this case it is deprecated in ORM 3.0

Error: Please provide a numeric version behind ".. deprecated::" instead of "ORM 3.0"
Error: Please provide a numeric version behind ".. deprecated::" instead of "ORM 3.0"
Error: Please only provide ".. deprecated::" if the version is greater/equal "5.0"

https://github.com/symfony/symfony-docs/actions/runs/10006460548/job/27659228920?pr=20052

Please advice

@xabbuh xabbuh added Doctrine hasPR A Pull Request has already been submitted for this issue. labels Jul 19, 2024
@javiereguiluz javiereguiluz removed the Waiting team decision Request for comments from Symfony Docs Team members label Jul 22, 2024
javiereguiluz added a commit that referenced this issue Jul 22, 2024
@javiereguiluz
minor #20052 Remove Doctrine mappings YML from documentation (Cosmin …
6972611 
…Sandu, cosminsandu)

This PR was merged into the 5.4 branch.

Discussion
----------

Remove Doctrine mappings YML from documentation

#20050

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `7.x` for features of unreleased versions).

-->

Commits
-------

d09a5ba issues/20050 Remove Doctrine mappings YML from documentation try to fix CI
a7d1540 Update reference/configuration/doctrine.rst
1a22c51 issues/20050 Remove Doctrine mappings YML from documentation #20050
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Jul 22, 2024
@javiereguiluz
Merge branch '5.4' into 6.4
97f905e 
* 5.4:
  Minor tweak
  issues/20050 Remove Doctrine mappings YML from documentation try to fix CI
  Update reference/configuration/doctrine.rst
  issues/20050 Remove Doctrine mappings YML from documentation symfony#20050

Signed-off-by: Javier Eguiluz <[email protected]>
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Jul 22, 2024
@javiereguiluz
Merge branch '6.4' into 7.0
72a7d11 
* 6.4:
  Minor tweak
  issues/20050 Remove Doctrine mappings YML from documentation try to fix CI
  Update reference/configuration/doctrine.rst
  issues/20050 Remove Doctrine mappings YML from documentation symfony#20050
@javiereguiluz
Copy link
Member

Closing as fixed in #20052.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Doctrine hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @cosminsandu