Add property types and return types in constraints #18362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jun 1, 2023
doctrine/resolve_target_entity.rst
Outdated
| @@ -69,7 +69,7 @@ An Invoice entity:: | |||
| * @var InvoiceSubjectInterface | |||
OskarStark
reviewed
Jun 1, 2023
OskarStark
reviewed
Jun 1, 2023
| @@ -112,7 +114,7 @@ that a date must at least be the next day: | |||
| class Order | |||
| { | |||
| #[Assert\GreaterThan('today')] | |||
| protected $deliveryDate; | |||
| protected \DateTime $deliveryDate; | |||
There was a problem hiding this comment.
Suggested change
| protected \DateTime $deliveryDate; | |
| protected \DateTimeInterface $deliveryDate; |
?
OskarStark
reviewed
Jun 1, 2023
| @@ -169,7 +173,7 @@ dates. If you want to fix the timezone, append it to the date string: | |||
| class Order | |||
| { | |||
| #[Assert\GreaterThan('today UTC')] | |||
| protected $deliveryDate; | |||
| protected \DateTime $deliveryDate; | |||
alexandre-daubois
force-pushed
the
missing-types-in-constraints
branch
from
b6c7f68
to
056a3bc
Compare
alexandre-daubois
force-pushed
the
missing-types-in-constraints
branch
from
056a3bc
to
2339f19
Compare
alexandre-daubois
force-pushed
the
missing-types-in-constraints
branch
from
2339f19
to
e33a140
Compare
|
Alex, thanks a million for the colossal effort of adding so many types 🙇🙇🙇 |
javiereguiluz
added a commit
that referenced
this pull request
Jul 23, 2024
…pe´ constraint is used (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [Validator] drop type-hints for properties where the ´Type´ constraint is used partially revert #18362 as having the native type-hints prevents the `Type` constraint to be applied in a meaningful way (if the types don't match, PHP will error before) Commits ------- 27a06be drop type-hints for properties where the Type constraint is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot a "few" ones in constraints 😄