Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "match parameter names with AbstractBundle" #19438

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 18, 2024

This reverts commit 6896b7e.

reverting #19321 to make the CI green again

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.4, 7.0, 7.1.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.3 milestone Jan 18, 2024
@xabbuh
Copy link
Member Author

xabbuh commented Jan 18, 2024

if we want to be able to resubmit #19321 we need to update DOCtor-RST first

@xabbuh xabbuh merged commit 8ac82c9 into symfony:6.3 Jan 18, 2024
3 checks passed
@xabbuh xabbuh deleted the pr-19321 branch January 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants