[Twig] [twig reference] add examples in yaml part #19640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
May 24, 2024
xabbuh
reviewed
May 24, 2024
xabbuh
reviewed
May 24, 2024
| {# output: { a: { c: e }, b: { d: f } } #} | ||
|
|
||
| {{ array|yaml_encode(1) }} | ||
| {# output: a: { c: e } b: { d: f } #} |
There was a problem hiding this comment.
This looks wrong to me. The top-level mapping needs to span multiple-lines if it doesn't use the inline syntax.
There was a problem hiding this comment.
I fixed this while merging. See 56d0815 I opted for always showing the output in a new line because otherwise is very confusing for output that generates more than 1 line.
xabbuh
reviewed
May 24, 2024
| {# output: %array% { a: { c: e }, b: { d: f } } #} | ||
|
|
||
| {{ array|yaml_dump(1) }} | ||
| {# output: %array% a: { c: e } b: { d: f } #} |
There was a problem hiding this comment.
see my comment above for yaml_encode
Sarah-eit
force-pushed
the
add_examples_in_yaml_part
branch
from
ca13f29
to
28ccb7f
Compare
carsonbot
changed the title
javiereguiluz
force-pushed
the
add_examples_in_yaml_part
branch
from
94eb5c0
to
346ea4b
Compare
|
This was finally merged! Thanks @Sarah-eit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.