Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Document #[AsMessage] attribute #20003

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

pounard
Copy link
Contributor

@pounard pounard commented Jun 28, 2024

Fixes #20002

Document the newly merged #[AsMessage] attribute symfony/symfony#57507

@pounard pounard requested a review from xabbuh as a code owner June 28, 2024 10:36
@pounard pounard changed the base branch from 7.1 to 7.2 June 28, 2024 10:36
@OskarStark OskarStark changed the title [Messenger] Document the #[AsMessage] attribute [Messenger] Document #[AsMessage] attribute Jun 28, 2024
@MrYamous
Copy link
Contributor

I think we should also add it to the Attribute Overwiew page

messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
@pounard
Copy link
Contributor Author

pounard commented Jul 3, 2024

Sorry, I took a few days off. I'll be back in a few days for fixing this.

@javiereguiluz
Copy link
Member

@pounard friendly ping. This is almost ready, so I hope you can find some time to finish it. Thanks a lot!

@pounard
Copy link
Contributor Author

pounard commented Aug 30, 2024

@pounard friendly ping. This is almost ready, so I hope you can find some time to finish it. Thanks a lot!

I'm sorry, I spent more time off work than it was initially planned. I will be back in september.

@pounard
Copy link
Contributor Author

pounard commented Sep 30, 2024

@MrYamous

I think we should also add it to the Attribute Overwiew page

I just added it, thanks for pointing this.

@pounard
Copy link
Contributor Author

pounard commented Sep 30, 2024

@javiereguiluz Ready for review once again! Sorry for keeping this waiting.

@pounard
Copy link
Contributor Author

pounard commented Sep 30, 2024

I have really no idea why the "Code Blocks" action fails. Any ideas?

@javiereguiluz javiereguiluz merged commit ffcb916 into symfony:7.2 Oct 16, 2024
2 of 3 checks passed
@javiereguiluz
Copy link
Member

Pierre, thanks for contributing this feature and its docs.

While merging, I reworded your contribution (See d926bbb). It looks like I changed everything ... but that's not true. I reused all your original contents, but merged them into the previous section. I did this because in the rest of the docs we always display the PHP attributes alongside the YAML/XML/PHP config files. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Messenger] Introduce #[AsMessage] attribute for message routing
7 participants