Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mentions where to find configCache #20035

Open
wants to merge 2 commits into
base: 7.1
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/dependency_injection/compilation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,8 @@ serves at dumping the compiled container::
The ``file_put_contents()`` function is not atomic. That could cause issues
in a production environment with multiple concurrent requests. Instead, use
the :ref:`dumpFile() method <filesystem-dumpfile>` from Symfony Filesystem
component or other methods provided by Symfony (e.g. ``$containerConfigCache->write()``)
component or other methods provided by Symfony (e.g. ``$containerConfigCache->write()``
which is part of the :doc:`Config component </components/config>`)
which are atomic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the atomic part relates to the method, not to the config component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark true, my point is just to mention where $containerConfigCache->write() may be found.
I think now it's correct, the part

  which are atomic.

goes after brackets and refers to component or other methods provided by Symfony


``ProjectServiceContainer`` is the default name given to the dumped container
Expand Down
Loading