[Serializer] add nullable format to defaultContext circularReference handler to prevent normalize error #20147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Aug 22, 2024
eltharin
force-pushed
the
correct_null_format
branch
from
8e5e5c6
to
117c0ae
Compare
xabbuh
approved these changes
Aug 22, 2024
OskarStark
approved these changes
Aug 22, 2024
carsonbot
changed the title
javiereguiluz
force-pushed
the
correct_null_format
branch
from
117c0ae
to
cba78d5
Compare
|
Thanks @eltharin ... and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add nullable $format parameter if this defaultContext is used with $serializer->normalize where $format can be nullable.
compress arguments with only seventh set.