Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] Add note on nuances of the Routing exclude config option #20241

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

toby-griffiths
Copy link
Contributor

As per reported issue symfony/symfony#39588,
currently the exclude option for attribute routing only works if the
resource value is a string, and is a glob pattern, so this updates the
example to use a glob pattern, and advise of this, current nuance.

@carsonbot carsonbot changed the title Add note on nuances of the Routing exclude config option [Routing] Add note on nuances of the Routing exclude config option Sep 19, 2024
@javiereguiluz javiereguiluz added this to the 6.4 milestone Oct 31, 2024
@javiereguiluz javiereguiluz changed the base branch from 7.1 to 6.4 October 31, 2024 16:33
@javiereguiluz javiereguiluz merged commit 04ccca1 into symfony:6.4 Oct 31, 2024
3 checks passed
@javiereguiluz
Copy link
Member

@toby-griffiths thanks for this contribution. This is indeed an annoying bug, so let's add a warning in the docs.

While merging I reworded this a bit (99427cb):

  • Don't use a glob in the resource option to avoid confusion (we don't use it anywhere else)
  • Extract the warning into a caution and move it outside of the YAML config example so it's more visible to readers

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants