Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

[WIP] commented usage of the templating sub-system #861

Closed
wants to merge 1 commit into from

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Sep 28, 2015

For 2.8, I'd like to promote a Twig-only approach. For this to happen:

  • We need to get rid of AsseticBundle (remove AsseticBundle #860)
  • We need to bump minimum versions of our deps (DoctrineBundle and SwitfmailerBundle) as a Twig-only approach only work when using the @Some/.../....html.twig notation

@weaverryan
Copy link
Member

@fabpot would this deprecate the AppBundle:Default:index.html.twig syntax and thus @App/Default/index.html.twig would become the recommended way?

@fabpot
Copy link
Member Author

fabpot commented Sep 29, 2015

@weaverryan It's more than that: without templating, the AppBundle:Default:index.html.twig syntax does not work at all, so @App/Default/index.html.twig would be the only way to reference templates. That's why we are using only the "new" notation internally (and third-party bundles should do the same by the way).

@weaverryan
Copy link
Member

@fabpot I thought that might be the case and I would also like to see that. I dislike the AppBundle:Default:index.html.twig syntax and the template locator stuff is quite convoluted. I do worry a little bit about people using @AppBundle on accident (which iirc resolves to the bundle root instead of Resources/views - or maybe it won't now?), but I have no evidence that this will be a real problem :).

@fabpot
Copy link
Member Author

fabpot commented Sep 21, 2016

sensiolabs/SensioFrameworkExtraBundle#431 is also a prerequisite as version 3 relies exclusively on the templating component.

Then, reading the Symfony docs, it should be updated as it still recommends using the old notation instead of the native Twig one.

@weaverryan
Copy link
Member

@fabpot issue opened for the docs about that: symfony/symfony-docs#7003

@Pierstoval
Copy link
Contributor

Does this PR have to be closed after SF4 + Flex announcements?

@stof
Copy link
Member

stof commented Apr 13, 2017

@weaverryan for Twig templates, @AppBundle does not resolve to anything by default

@fabpot fabpot closed this Apr 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants