Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpClient] Add JsonMockResponse::fromFile() and MockResponse::fromFile() shortcuts #52970

Merged
merged 1 commit into from
Dec 17, 2023
Merged

[HttpClient] Add JsonMockResponse::fromFile() and MockResponse::fromFile() shortcuts #52970

merged 1 commit into from
Dec 17, 2023

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Dec 9, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

I have noticed I use a lot of file fixtures for tests since they are more readable as stand-alone files.

I think adding small shortcut methods would help the DX.

@carsonbot carsonbot added this to the 7.1 milestone Dec 9, 2023
@fancyweb fancyweb force-pushed the http-client/mock-from-file branch 3 times, most recently from e3e831f to 0d7dce6 Compare December 9, 2023 13:36
@OskarStark
Copy link
Contributor

I am not really sold on the new $json parameter 🤔 Could't we just check if the data is_string() and remove the additional parameter?

@fancyweb
Copy link
Contributor Author

fancyweb commented Dec 9, 2023

We can't do the is_string trick because we already allow passing a string.

@fabpot
Copy link
Member

fabpot commented Dec 17, 2023

Thank you @fancyweb.

@fabpot fabpot merged commit e595c52 into symfony:7.1 Dec 17, 2023
3 of 9 checks passed
@fabpot fabpot mentioned this pull request Dec 17, 2023
Closed
@fancyweb fancyweb deleted the http-client/mock-from-file branch December 18, 2023 08:32
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@welcoMattic welcoMattic welcoMattic approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Hack Day HttpClient Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@fancyweb @OskarStark @fabpot @welcoMattic @carsonbot