[String] Fix Inflector for 'hardware' #57234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase to get rid of the merge commit and maybe rebase on 5.4? |
OskarStark
approved these changes
Jun 1, 2024
OskarStark
approved these changes
Jun 2, 2024
fabpot
force-pushed
the
inflector_plural_hardware
branch
from
16c4691
to
c655569
Compare
fabpot
approved these changes
Jun 3, 2024
|
Thank you @podhy. |
|
@fabpot sorry for missing rebase. Had holiday. Thank you for merge. |
Merged
This was referenced Jun 28, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR fixes problem when inflecting
hardwareword intohardwares. This word should not be inflected.Please make someone review because I'm not 100% sure if this is the right way how to fix it.
Thank you.
Btw: older versions are also affected and it should be possible to merge it there