Skip to content

Commit

Permalink
[Uid] Ensure UuidV1 is created in lowercase
Browse files Browse the repository at this point in the history
  • Loading branch information
smnandre authored and chalasr committed Jul 31, 2024
1 parent 3e85f7b commit 886c174
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 9 additions & 0 deletions Tests/UuidTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,15 @@ public function testV1()
$this->assertSame('3499710062d0', $uuid->getNode());
}

public function testV1IsLowerCase()
{
$uuid = new UuidV1();
$this->assertSame(strtolower((string) $uuid), (string) $uuid);

$uuid = new UuidV1('D9E7A184-5D5B-11EA-A62A-3499710062D0');
$this->assertSame(strtolower((string) $uuid), (string) $uuid);
}

public function testV3()
{
$uuid = Uuid::v3(new UuidV4(self::A_UUID_V4), 'the name');
Expand Down
2 changes: 1 addition & 1 deletion UuidV1.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class UuidV1 extends Uuid
public function __construct(?string $uuid = null)
{
if (null === $uuid) {
$this->uid = uuid_create(static::TYPE);
$this->uid = strtolower(uuid_create(static::TYPE));
} else {
parent::__construct($uuid, true);
}
Expand Down

0 comments on commit 886c174

Please sign in to comment.