[Turbo][Tests] debug

symfony · Oct 3, 2024 · 2264ff2 · 2264ff2
1 parent b0f7da9
commit 2264ff2
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 6 deletions.
diff --git a/.github/workflows/test-turbo.yml b/.github/workflows/test-turbo.yml
@@ -84,6 +84,10 @@ jobs:
             - name: Install JavaScript dependencies
               working-directory: src/Turbo/tests/app
               run: php public/index.php importmap:install
+
+            - name: Compile assets
+              working-directory: src/Turbo/tests/app
+              run: php public/index.php asset-map:compile
 
             - name: Create DB
               working-directory: src/Turbo/tests/app
@@ -96,3 +100,12 @@ jobs:
                 vendor/bin/simple-phpunit
               env:
                   SYMFONY_DEPRECATIONS_HELPER: 'max[self]=1'
+
+            - name: Upload Panther error screenshots
+              if: ${{ always() }}
+              uses: actions/upload-artifact@v4
+              with:
+                name: Panther error screenshots (PHP ${{ matrix.php-version }}, Deps ${{ matrix.dependency-version }})
+                path: src/Turbo/tests/app/var/error-screenshots
+                if-no-files-found: ignore
+                retention-days: 3
diff --git a/src/Turbo/.gitignore b/src/Turbo/.gitignore
@@ -5,7 +5,7 @@
 /composer.lock
 /phpunit.xml
 /vendor/
+/drivers/
 /tests/app/assets/vendor/
 /tests/app/var/
-/tests/app/public/build/
-node_modules/
+/tests/app/public/assets/
diff --git a/src/Turbo/composer.json b/src/Turbo/composer.json
@@ -56,7 +56,6 @@
         "symfony/ux-twig-component": "^2.21",
         "symfony/twig-bundle": "^6.4|^7.0",
         "symfony/web-profiler-bundle": "^5.4|^6.0|^7.0",
-        "symfony/webpack-encore-bundle": "^2.1.1",
         "symfony/expression-language": "^5.4|^6.0|^7.0",
         "dbrekelmans/bdi": "dev-main"
     },

diff --git a/src/Turbo/phpunit.xml.dist b/src/Turbo/phpunit.xml.dist
@@ -15,6 +15,7 @@
         <server name="KERNEL_CLASS" value="App\Kernel" />
         <server name="PANTHER_WEB_SERVER_DIR" value="./tests/app/public" />
         <server name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0&amp;max[direct]=0"/>
+        <server name="PANTHER_ERROR_SCREENSHOT_DIR" value="./tests/app/var/error-screenshots"/>
     </php>
 
     <testsuites>

diff --git a/src/Turbo/tests/app/Kernel.php b/src/Turbo/tests/app/Kernel.php
@@ -39,7 +39,6 @@
 use Symfony\UX\StimulusBundle\StimulusBundle;
 use Symfony\UX\Turbo\TurboBundle;
 use Symfony\UX\TwigComponent\TwigComponentBundle;
-use Symfony\WebpackEncoreBundle\WebpackEncoreBundle;
 use Twig\Environment;
 
 /**
@@ -57,7 +56,6 @@ public function registerBundles(): iterable
         yield new MercureBundle();
         yield new TwigComponentBundle();
         yield new TurboBundle();
-        yield new WebpackEncoreBundle();
         yield new StimulusBundle();
         yield new WebProfilerBundle();
         yield new DebugBundle();
@@ -111,7 +109,6 @@ protected function configureContainer(ContainerConfigurator $container): void
         $container
             ->extension('doctrine', $doctrineConfig);
 
-        $container->extension('webpack_encore', ['output_path' => 'build']);
         $container->extension('web_profiler', [
             'toolbar' => true,
             'intercept_redirects' => false,